Messages in this thread | | | Date | Tue, 23 Aug 2022 17:15:15 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver |
| |
On Fri, Aug 05, 2022 at 02:03:43PM +0200, Henning Schild wrote: > If we register a "leds-gpio" platform device for GPIO pins that do not > exist we get a -EPROBE_DEFER and the probe will be tried again later. > If there is not driver to provide that pin we will poll forever and also > create a lot of log messages. > > So check if that GPIO driver is configured, if so it will come up > eventually. If not we exit our probe function early and do not even > bother registering the "leds-gpio". This method was chosen over "Kconfig > depends" since this way we can add support for more devices and GPIO > backends more easily without "depends"ing on all GPIO backends.
Not sure what we should do with this patch due to your self-reply on it. So, if it's still needed, I would expect a new version / resend.
-- With Best Regards, Andy Shevchenko
| |