Messages in this thread | | | Date | Tue, 23 Aug 2022 13:40:40 +0300 | Subject | Re: [PATCH v4 1/6] dt-bindings: net: dsa: mediatek,mt7530: make trivial changes | From | Krzysztof Kozlowski <> |
| |
On 20/08/2022 11:07, Arınç ÜNAL wrote: > Make trivial changes on the binding. > > - Update title to include MT7531 switch. > - Add me as a maintainer. List maintainers in alphabetical order by first > name. > - Add description to compatible strings. > - Stretch descriptions up to the 80 character limit. > - Remove quotes from $ref: "dsa.yaml#". > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 36 ++++++++++++------- > 1 file changed, 24 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 17ab6c69ecc7..edf48e917173 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -4,12 +4,13 @@ > $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Mediatek MT7530 Ethernet switch > +title: Mediatek MT7530 and MT7531 Ethernet Switches > > maintainers: > - - Sean Wang <sean.wang@mediatek.com> > + - Arınç ÜNAL <arinc.unal@arinc9.com> > - Landen Chao <Landen.Chao@mediatek.com> > - DENG Qingfang <dqfext@gmail.com> > + - Sean Wang <sean.wang@mediatek.com> > > description: | > Port 5 of mt7530 and mt7621 switch is muxed between: > @@ -61,10 +62,21 @@ description: | > > properties: > compatible: > - enum: > - - mediatek,mt7530 > - - mediatek,mt7531 > - - mediatek,mt7621 > + oneOf: > + - description: > + Standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC > + items:
You have one item, so don't make it a list. Just const:xxxxx
Same in other places.
Best regards, Krzysztof
| |