Messages in this thread | | | Date | Tue, 23 Aug 2022 13:24:25 +0200 | From | Greg KH <> | Subject | Re: [PATCH RFC char-misc-next 1/5] misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device. |
| |
On Thu, Aug 04, 2022 at 10:02:15PM +0530, Kumaravel Thiagarajan wrote: > +// SPDX-License-Identifier: GPL-2.0+
I have to ask, do you really mean "or any later version" like you are saying here?
> +// Copyright (C) 2022 Microchip Technology Inc. > + > +#include <linux/mfd/core.h> > +#include <linux/module.h> > +#include <linux/pci.h> > +#include <linux/spinlock.h> > +#include <linux/gpio/driver.h> > +#include <linux/interrupt.h> > +#include <linux/io.h> > +#include <linux/idr.h> > +#include "mchp_pci1xxxx_gp.h" > + > +struct aux_bus_device { > + struct auxiliary_device_wrapper *aux_device_wrapper[2]; > +}; > + > +DEFINE_IDA(gp_client_ida);
Shouldn't this be static?
thanks,
greg k-h
| |