Messages in this thread | | | Date | Tue, 23 Aug 2022 12:45:26 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2] binderfs: rework superblock destruction |
| |
On Tue, Aug 23, 2022 at 11:53:39AM +0200, Christian Brauner wrote: > From: Al Viro <viro@zeniv.linux.org.uk> > > So far we relied on > .put_super = binderfs_put_super() > to destroy info we stashed in sb->s_fs_info. This gave us the required ordering > between ->evict_inode() and sb->s_fs_info destruction. > > But the current implementation of binderfs_fill_super() has a memory leak in > the rare circumstance that d_make_root() fails because ->put_super() is only > called when sb->s_root is initialized. Fix this by removing ->put_super() and > simply do all that work in binderfs_kill_super(). > > Reported-by: Dongliang Mu <mudongliangabcd@gmail.com> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org> > --- > drivers/android/binderfs.c | 30 +++++++++++++++++------------- > 1 file changed, 17 insertions(+), 13 deletions(-)
What changed from v1?
| |