lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 103/158] platform/chrome: cros_ec_proto: dont show MKBP version if unsupported
    Date
    From: Tzung-Bi Shih <tzungbi@kernel.org>

    [ Upstream commit b36f0643ff14a2fb281b105418e4e73c9d7c11d0 ]

    It wrongly showed the following message when it doesn't support MKBP:
    "MKBP support version 4294967295".

    Fix it.

    Reviewed-by: Guenter Roeck <groeck@chromium.org>
    Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
    Link: https://lore.kernel.org/r/20220609084957.3684698-14-tzungbi@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/chrome/cros_ec_proto.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
    index e1fadf059e05..3a2a78ff3330 100644
    --- a/drivers/platform/chrome/cros_ec_proto.c
    +++ b/drivers/platform/chrome/cros_ec_proto.c
    @@ -507,13 +507,13 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
    ret = cros_ec_get_host_command_version_mask(ec_dev,
    EC_CMD_GET_NEXT_EVENT,
    &ver_mask);
    - if (ret < 0 || ver_mask == 0)
    + if (ret < 0 || ver_mask == 0) {
    ec_dev->mkbp_event_supported = 0;
    - else
    + } else {
    ec_dev->mkbp_event_supported = fls(ver_mask);

    - dev_dbg(ec_dev->dev, "MKBP support version %u\n",
    - ec_dev->mkbp_event_supported - 1);
    + dev_dbg(ec_dev->dev, "MKBP support version %u\n", ec_dev->mkbp_event_supported - 1);
    + }

    /* Probe if host sleep v1 is supported for S0ix failure detection. */
    ret = cros_ec_get_host_command_version_mask(ec_dev,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 14:24    [W:4.188 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site