lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 363/389] selftests/kprobe: Do not test for GRP/ without event failures
    Date
    From: Steven Rostedt (Google) <rostedt@goodmis.org>

    [ Upstream commit f5eab65ff2b76449286d18efc7fee3e0b72f7d9b ]

    A new feature is added where kprobes (and other probes) do not need to
    explicitly state the event name when creating a probe. The event name will
    come from what is being attached.

    That is:

    # echo 'p:foo/ vfs_read' > kprobe_events

    Will no longer error, but instead create an event:

    # cat kprobe_events
    p:foo/p_vfs_read_0 vfs_read

    This should not be tested as an error case anymore. Remove it from the
    selftest as now this feature "breaks" the selftest as it no longer fails
    as expected.

    Link: https://lore.kernel.org/all/1656296348-16111-1-git-send-email-quic_linyyuan@quicinc.com/
    Link: https://lkml.kernel.org/r/20220712161707.6dc08a14@gandalf.local.home

    Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    .../selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
    index ef1e9bafb098..728c2762ee58 100644
    --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
    +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
    @@ -24,7 +24,6 @@ check_error 'p:^/bar vfs_read' # NO_GROUP_NAME
    check_error 'p:^12345678901234567890123456789012345678901234567890123456789012345/bar vfs_read' # GROUP_TOO_LONG

    check_error 'p:^foo.1/bar vfs_read' # BAD_GROUP_NAME
    -check_error 'p:foo/^ vfs_read' # NO_EVENT_NAME
    check_error 'p:foo/^12345678901234567890123456789012345678901234567890123456789012345 vfs_read' # EVENT_TOO_LONG
    check_error 'p:foo/^bar.1 vfs_read' # BAD_EVENT_NAME

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 14:04    [W:2.275 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site