lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 324/389] nfp: ethtool: fix the display error of `ethtool -m DEVNAME`
    Date
    From: Yu Xiao <yu.xiao@corigine.com>

    commit 4ae97cae07e15d41e5c0ebabba64c6eefdeb0bbe upstream.

    The port flag isn't set to `NFP_PORT_CHANGED` when using
    `ethtool -m DEVNAME` before, so the port state (e.g. interface)
    cannot be updated. Therefore, it caused that `ethtool -m DEVNAME`
    sometimes cannot read the correct information.

    E.g. `ethtool -m DEVNAME` cannot work when load driver before plug
    in optical module, as the port interface is still NONE without port
    update.

    Now update the port state before sending info to NIC to ensure that
    port interface is correct (latest state).

    Fixes: 61f7c6f44870 ("nfp: implement ethtool get module EEPROM")
    Reviewed-by: Louis Peens <louis.peens@corigine.com>
    Signed-off-by: Yu Xiao <yu.xiao@corigine.com>
    Signed-off-by: Simon Horman <simon.horman@corigine.com>
    Link: https://lore.kernel.org/r/20220802093355.69065-1-simon.horman@corigine.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
    +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
    @@ -1127,6 +1127,8 @@ nfp_port_get_module_info(struct net_devi
    u8 data;

    port = nfp_port_from_netdev(netdev);
    + /* update port state to get latest interface */
    + set_bit(NFP_PORT_CHANGED, &port->flags);
    eth_port = nfp_port_get_eth_port(port);
    if (!eth_port)
    return -EOPNOTSUPP;

    \
     
     \ /
      Last update: 2022-08-23 13:55    [W:4.351 / U:0.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site