lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 317/389] plip: avoid rcu debug splat
    Date
    From: Florian Westphal <fw@strlen.de>

    commit bc3c8fe3c79bcdae4d90e3726054fac5cca8ac32 upstream.

    WARNING: suspicious RCU usage
    5.2.0-rc2-00605-g2638eb8b50cfc #1 Not tainted
    drivers/net/plip/plip.c:1110 suspicious rcu_dereference_check() usage!

    plip_open is called with RTNL held, switch to the correct helper.

    Fixes: 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list")
    Reported-by: kernel test robot <oliver.sang@intel.com>
    Signed-off-by: Florian Westphal <fw@strlen.de>
    Link: https://lore.kernel.org/r/20220807115304.13257-1-fw@strlen.de
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/plip/plip.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/plip/plip.c
    +++ b/drivers/net/plip/plip.c
    @@ -1103,7 +1103,7 @@ plip_open(struct net_device *dev)
    /* Any address will do - we take the first. We already
    have the first two bytes filled with 0xfc, from
    plip_init_dev(). */
    - const struct in_ifaddr *ifa = rcu_dereference(in_dev->ifa_list);
    + const struct in_ifaddr *ifa = rtnl_dereference(in_dev->ifa_list);
    if (ifa != NULL) {
    memcpy(dev->dev_addr+2, &ifa->ifa_local, 4);
    }

    \
     
     \ /
      Last update: 2022-08-23 13:54    [W:4.099 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site