lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 282/389] Revert "net: usb: ax88179_178a needs FLAG_SEND_ZLP"
    Date
    From: Jose Alonso <joalonsof@gmail.com>

    commit 6fd2c17fb6e02a8c0ab51df1cfec82ce96b8e83d upstream.

    This reverts commit 36a15e1cb134c0395261ba1940762703f778438c.

    The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
    versions that have no issues.

    The FLAG_SEND_ZLP is not safe to use in this context.
    See:
    https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
    The original problem needs another way to solve.

    Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
    Cc: stable@vger.kernel.org
    Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
    Link: https://bugs.archlinux.org/task/75491
    Signed-off-by: Jose Alonso <joalonsof@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/usb/ax88179_178a.c | 16 ++++++++--------
    1 file changed, 8 insertions(+), 8 deletions(-)

    --- a/drivers/net/usb/ax88179_178a.c
    +++ b/drivers/net/usb/ax88179_178a.c
    @@ -1690,7 +1690,7 @@ static const struct driver_info ax88179_
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
    };
    @@ -1703,7 +1703,7 @@ static const struct driver_info ax88178a
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
    };
    @@ -1716,7 +1716,7 @@ static const struct driver_info cypress_
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
    };
    @@ -1729,7 +1729,7 @@ static const struct driver_info dlink_du
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
    };
    @@ -1742,7 +1742,7 @@ static const struct driver_info sitecom_
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
    };
    @@ -1755,7 +1755,7 @@ static const struct driver_info samsung_
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
    };
    @@ -1768,7 +1768,7 @@ static const struct driver_info lenovo_i
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
    };
    @@ -1781,7 +1781,7 @@ static const struct driver_info belkin_i
    .link_reset = ax88179_link_reset,
    .reset = ax88179_reset,
    .stop = ax88179_stop,
    - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
    + .flags = FLAG_ETHER | FLAG_FRAMING_AX,
    .rx_fixup = ax88179_rx_fixup,
    .tx_fixup = ax88179_tx_fixup,
    };

    \
     
     \ /
      Last update: 2022-08-23 13:49    [W:2.986 / U:1.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site