lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 190/389] mmc: cavium-thunderx: Add of_node_put() when breaking out of loop
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 7ee480795e41db314f2c445c65ed854a5d6e8e32 ]

    In thunder_mmc_probe(), we should call of_node_put() when breaking
    out of for_each_child_of_node() which has increased and decreased
    the refcount during each iteration.

    Fixes: 166bac38c3c5 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs")
    Signed-off-by: Liang He <windhl@126.com>
    Acked-by: Robert Richter <rric@kernel.org>
    Link: https://lore.kernel.org/r/20220719095216.1241601-2-windhl@126.com
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/cavium-thunderx.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/cavium-thunderx.c b/drivers/mmc/host/cavium-thunderx.c
    index eee08d81b242..f79806e31e7e 100644
    --- a/drivers/mmc/host/cavium-thunderx.c
    +++ b/drivers/mmc/host/cavium-thunderx.c
    @@ -138,8 +138,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev,
    continue;

    ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host);
    - if (ret)
    + if (ret) {
    + of_node_put(child_node);
    goto error;
    + }
    }
    i++;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 13:35    [W:4.102 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site