lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 180/389] memstick/ms_block: Fix a memory leak
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 54eb7a55be6779c4d0c25eaf5056498a28595049 ]

    'erased_blocks_bitmap' is never freed. As it is allocated at the same time
    as 'used_blocks_bitmap', it is likely that it should be freed also at the
    same time.

    Add the corresponding bitmap_free() in msb_data_clear().

    Fixes: 0ab30494bc4f ("memstick: add support for legacy memorysticks")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/b3b78926569445962ea5c3b6e9102418a9effb88.1656155715.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memstick/core/ms_block.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
    index 399510585245..6014fcb49d7e 100644
    --- a/drivers/memstick/core/ms_block.c
    +++ b/drivers/memstick/core/ms_block.c
    @@ -1954,6 +1954,7 @@ static void msb_data_clear(struct msb_data *msb)
    {
    kfree(msb->boot_page);
    bitmap_free(msb->used_blocks_bitmap);
    + bitmap_free(msb->erased_blocks_bitmap);
    kfree(msb->lba_to_pba_table);
    kfree(msb->cache);
    msb->card = NULL;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 13:35    [W:4.088 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site