lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 095/389] ath10k: do not enforce interrupt trigger type
    Date
    From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    [ Upstream commit 1ee6c5abebd3cacf2ac4378d0ed4f57fd4850421 ]

    Interrupt line can be configured on different hardware in different way,
    even inverted. Therefore driver should not enforce specific trigger
    type - edge rising - but instead rely on Devicetree to configure it.

    All Qualcomm DTSI with WCN3990 define the interrupt type as level high,
    so the mismatch between DTSI and driver causes rebind issues:

    $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/unbind
    $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/bind
    [ 44.763114] irq: type mismatch, failed to map hwirq-446 for interrupt-controller@17a00000!
    [ 44.763130] ath10k_snoc 18800000.wifi: error -ENXIO: IRQ index 0 not found
    [ 44.763140] ath10k_snoc 18800000.wifi: failed to initialize resource: -6

    Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.0.c8-00009-QCAHLSWSC8180XMTPLZ-1
    Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1

    Fixes: c963a683e701 ("ath10k: add resource init and deinit for WCN3990")
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Tested-by: Steev Klimaszewski <steev@kali.org>
    Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
    Link: https://lore.kernel.org/r/20220513151516.357549-1-krzysztof.kozlowski@linaro.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath10k/snoc.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
    index d4589b2ab3b6..b6762fe2efe2 100644
    --- a/drivers/net/wireless/ath/ath10k/snoc.c
    +++ b/drivers/net/wireless/ath/ath10k/snoc.c
    @@ -1192,13 +1192,12 @@ static void ath10k_snoc_init_napi(struct ath10k *ar)
    static int ath10k_snoc_request_irq(struct ath10k *ar)
    {
    struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
    - int irqflags = IRQF_TRIGGER_RISING;
    int ret, id;

    for (id = 0; id < CE_COUNT_MAX; id++) {
    ret = request_irq(ar_snoc->ce_irqs[id].irq_line,
    - ath10k_snoc_per_engine_handler,
    - irqflags, ce_name[id], ar);
    + ath10k_snoc_per_engine_handler, 0,
    + ce_name[id], ar);
    if (ret) {
    ath10k_err(ar,
    "failed to register IRQ handler for CE %d: %d",
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 13:23    [W:4.495 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site