lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 091/389] regulator: of: Fix refcount leak bug in of_get_regulation_constraints()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 66efb665cd5ad69b27dca8571bf89fc6b9c628a4 ]

    We should call the of_node_put() for the reference returned by
    of_get_child_by_name() which has increased the refcount.

    Fixes: 40e20d68bb3f ("regulator: of: Add support for parsing regulator_state for suspend state")
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220715111027.391032-1-windhl@126.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/of_regulator.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
    index 87637eb6bcbc..7a0a235e4465 100644
    --- a/drivers/regulator/of_regulator.c
    +++ b/drivers/regulator/of_regulator.c
    @@ -206,8 +206,12 @@ static int of_get_regulation_constraints(struct device *dev,
    }

    suspend_np = of_get_child_by_name(np, regulator_states[i]);
    - if (!suspend_np || !suspend_state)
    + if (!suspend_np)
    continue;
    + if (!suspend_state) {
    + of_node_put(suspend_np);
    + continue;
    + }

    if (!of_property_read_u32(suspend_np, "regulator-mode",
    &pval)) {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 13:20    [W:2.871 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site