lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 033/389] drm/amdgpu: Check BOs requested pinning domains against its preferred_domains
    Date
    From: Leo Li <sunpeng.li@amd.com>

    commit f5ba14043621f4afdf3ad5f92ee2d8dbebbe4340 upstream.

    When pinning a buffer, we should check to see if there are any
    additional restrictions imposed by bo->preferred_domains. This will
    prevent the BO from being moved to an invalid domain when pinning.

    For example, this can happen if the user requests to create a BO in GTT
    domain for display scanout. amdgpu_dm will allow pinning to either VRAM
    or GTT domains, since DCN can scanout from either or. However, in
    amdgpu_bo_pin_restricted(), pinning to VRAM is preferred if there is
    adequate carveout. This can lead to pinning to VRAM despite the user
    requesting GTT placement for the BO.

    v2: Allow the kernel to override the domain, which can happen when
    exporting a BO to a V4L camera (for example).

    Signed-off-by: Leo Li <sunpeng.li@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
    @@ -892,6 +892,10 @@ int amdgpu_bo_pin_restricted(struct amdg
    if (WARN_ON_ONCE(min_offset > max_offset))
    return -EINVAL;

    + /* Check domain to be pinned to against preferred domains */
    + if (bo->preferred_domains & domain)
    + domain = bo->preferred_domains & domain;
    +
    /* A shared bo cannot be migrated to VRAM */
    if (bo->prime_shared_count) {
    if (domain & AMDGPU_GEM_DOMAIN_GTT)

    \
     
     \ /
      Last update: 2022-08-23 13:17    [W:4.601 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site