lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 056/389] genirq: Dont return error on missing optional irq_request_resources()
    Date
    From: Antonio Borneo <antonio.borneo@foss.st.com>

    [ Upstream commit 95001b756467ecc9f5973eb5e74e97699d9bbdf1 ]

    Function irq_chip::irq_request_resources() is reported as optional
    in the declaration of struct irq_chip.
    If the parent irq_chip does not implement it, we should ignore it
    and return.

    Don't return error if the functions is missing.

    Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20220512160544.13561-1-antonio.borneo@foss.st.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/irq/chip.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
    index 856f0297dc73..521121c2666c 100644
    --- a/kernel/irq/chip.c
    +++ b/kernel/irq/chip.c
    @@ -1484,7 +1484,8 @@ int irq_chip_request_resources_parent(struct irq_data *data)
    if (data->chip->irq_request_resources)
    return data->chip->irq_request_resources(data);

    - return -ENOSYS;
    + /* no error on missing optional irq_chip::irq_request_resources */
    + return 0;
    }
    EXPORT_SYMBOL_GPL(irq_chip_request_resources_parent);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 13:15    [W:2.074 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site