lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 218/287] mmc: pxamci: Fix another error handling path in pxamci_probe()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit b886f54c300d31c109d2e4336b22922b64e7ba7d upstream.

    The commit in Fixes: has introduced an new error handling without branching
    to the existing error handling path.

    Update it now and release some resources if pxamci_init_ocr() fails.

    Fixes: 61951fd6cb49 ("mmc: pxamci: let mmc core handle regulators")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/07a2dcebf8ede69b484103de8f9df043f158cffd.1658862932.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/mmc/host/pxamci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mmc/host/pxamci.c
    +++ b/drivers/mmc/host/pxamci.c
    @@ -677,7 +677,7 @@ static int pxamci_probe(struct platform_

    ret = pxamci_init_ocr(host);
    if (ret < 0)
    - return ret;
    + goto out;

    mmc->caps = 0;
    host->cmdat = 0;

    \
     
     \ /
      Last update: 2022-08-23 12:55    [W:2.313 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site