lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 171/287] powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 6ac059dacffa8ab2f7798f20e4bd3333890c541c ]

    of_find_node_by_path() returns remote device nodepointer with
    refcount incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 0afacde3df4c ("[POWERPC] spufs: allow isolated mode apps by starting the SPE loader")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Acked-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20220603121543.22884-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/cell/spufs/inode.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
    index db329d4bf1c3..8b664d9cfcd4 100644
    --- a/arch/powerpc/platforms/cell/spufs/inode.c
    +++ b/arch/powerpc/platforms/cell/spufs/inode.c
    @@ -684,6 +684,7 @@ spufs_init_isolated_loader(void)
    return;

    loader = of_get_property(dn, "loader", &size);
    + of_node_put(dn);
    if (!loader)
    return;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 12:49    [W:2.325 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site