lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 108/287] wifi: libertas: Fix possible refcount leak in if_usb_probe()
    Date
    From: Hangyu Hua <hbh25y@gmail.com>

    [ Upstream commit 6fd57e1d120bf13d4dc6c200a7cf914e6347a316 ]

    usb_get_dev will be called before lbs_get_firmware_async which means that
    usb_put_dev need to be called when lbs_get_firmware_async fails.

    Fixes: ce84bb69f50e ("libertas USB: convert to asynchronous firmware loading")
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    Signed-off-by: Kalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/20220620092350.39960-1-hbh25y@gmail.com
    Link: https://lore.kernel.org/r/20220622113402.16969-1-colin.i.king@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/marvell/libertas/if_usb.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c
    index f29a154d995c..d75763410cdc 100644
    --- a/drivers/net/wireless/marvell/libertas/if_usb.c
    +++ b/drivers/net/wireless/marvell/libertas/if_usb.c
    @@ -283,6 +283,7 @@ static int if_usb_probe(struct usb_interface *intf,
    return 0;

    err_get_fw:
    + usb_put_dev(udev);
    lbs_remove_card(priv);
    err_add_card:
    if_usb_reset_device(cardp);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 12:45    [W:2.287 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site