lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 136/287] mmc: cavium-octeon: Add of_node_put() when breaking out of loop
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 19bbb49acf8d7a03cb83e05624363741a4c3ec6f ]

    In octeon_mmc_probe(), we should call of_node_put() when breaking
    out of for_each_child_of_node() which has increased and decreased
    the refcount during each iteration.

    Fixes: 01d95843335c ("mmc: cavium: Add MMC support for Octeon SOCs.")
    Signed-off-by: Liang He <windhl@126.com>
    Acked-by: Robert Richter <rric@kernel.org>
    Link: https://lore.kernel.org/r/20220719095216.1241601-1-windhl@126.com
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/cavium-octeon.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mmc/host/cavium-octeon.c b/drivers/mmc/host/cavium-octeon.c
    index 22aded1065ae..2245452a44c8 100644
    --- a/drivers/mmc/host/cavium-octeon.c
    +++ b/drivers/mmc/host/cavium-octeon.c
    @@ -288,6 +288,7 @@ static int octeon_mmc_probe(struct platform_device *pdev)
    if (ret) {
    dev_err(&pdev->dev, "Error populating slots\n");
    octeon_mmc_set_shared_power(host, 0);
    + of_node_put(cn);
    goto error;
    }
    i++;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 12:45    [W:4.050 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site