lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 121/287] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 302970b4cad3ebfda2c05ce06c322ccdc447d17e ]

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 73108aa90cbf ("USB: ohci-nxp: Use isp1301 driver")
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220603141231.979-1-linmq006@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/ohci-nxp.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
    index f5f532601092..a964a93ff35b 100644
    --- a/drivers/usb/host/ohci-nxp.c
    +++ b/drivers/usb/host/ohci-nxp.c
    @@ -153,6 +153,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
    }

    isp1301_i2c_client = isp1301_get_client(isp1301_node);
    + of_node_put(isp1301_node);
    if (!isp1301_i2c_client)
    return -EPROBE_DEFER;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 12:44    [W:4.776 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site