lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 120/287] usb: host: Fix refcount leak in ehci_hcd_ppc_of_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit b5c5b13cb45e2c88181308186b0001992cb41954 ]

    of_find_compatible_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 796bcae7361c ("USB: powerpc: Workaround for the PPC440EPX USBH_23 errata [take 3]")
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220602110849.58549-1-linmq006@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/ehci-ppc-of.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/host/ehci-ppc-of.c b/drivers/usb/host/ehci-ppc-of.c
    index 576f7d79ad4e..d1dc644b215c 100644
    --- a/drivers/usb/host/ehci-ppc-of.c
    +++ b/drivers/usb/host/ehci-ppc-of.c
    @@ -148,6 +148,7 @@ static int ehci_hcd_ppc_of_probe(struct platform_device *op)
    } else {
    ehci->has_amcc_usb23 = 1;
    }
    + of_node_put(np);
    }

    if (of_get_property(dn, "big-endian", NULL)) {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 12:44    [W:4.076 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site