lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 115/287] mtd: maps: Fix refcount leak in ap_flash_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 77087a04c8fd554134bddcb8a9ff87b21f357926 ]

    of_find_matching_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20220523143255.4376-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/maps/physmap_of_versatile.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mtd/maps/physmap_of_versatile.c b/drivers/mtd/maps/physmap_of_versatile.c
    index 961704228dd2..7d56e97bd50f 100644
    --- a/drivers/mtd/maps/physmap_of_versatile.c
    +++ b/drivers/mtd/maps/physmap_of_versatile.c
    @@ -107,6 +107,7 @@ static int ap_flash_init(struct platform_device *pdev)
    return -ENODEV;
    }
    ebi_base = of_iomap(ebi, 0);
    + of_node_put(ebi);
    if (!ebi_base)
    return -ENODEV;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 12:44    [W:4.092 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site