lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 210/244] mips: cavium-octeon: Fix missing of_node_put() in octeon2_usb_clocks_start
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 7a9f743ceead60ed454c46fbc3085ee9a79cbebb ]

    We should call of_node_put() for the reference 'uctl_node' returned by
    of_get_parent() which will increase the refcount. Otherwise, there will
    be a refcount leak bug.

    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/cavium-octeon/octeon-platform.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
    index a994022e32c9..ce05c0dd3acd 100644
    --- a/arch/mips/cavium-octeon/octeon-platform.c
    +++ b/arch/mips/cavium-octeon/octeon-platform.c
    @@ -86,11 +86,12 @@ static void octeon2_usb_clocks_start(struct device *dev)
    "refclk-frequency", &clock_rate);
    if (i) {
    dev_err(dev, "No UCTL \"refclk-frequency\"\n");
    + of_node_put(uctl_node);
    goto exit;
    }
    i = of_property_read_string(uctl_node,
    "refclk-type", &clock_type);
    -
    + of_node_put(uctl_node);
    if (!i && strcmp("crystal", clock_type) == 0)
    is_crystal_clock = true;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-23 12:28    [W:4.487 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site