lkml.org 
[lkml]   [2022]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 156/229] ext4: fix extent status tree race in writeback error recovery path
    Date
    From: Eric Whitney <enwlinux@gmail.com>

    commit 7f0d8e1d607c1a4fa9a27362a108921d82230874 upstream.

    A race can occur in the unlikely event ext4 is unable to allocate a
    physical cluster for a delayed allocation in a bigalloc file system
    during writeback. Failure to allocate a cluster forces error recovery
    that includes a call to mpage_release_unused_pages(). That function
    removes any corresponding delayed allocated blocks from the extent
    status tree. If a new delayed write is in progress on the same cluster
    simultaneously, resulting in the addition of an new extent containing
    one or more blocks in that cluster to the extent status tree, delayed
    block accounting can be thrown off if that delayed write then encounters
    a similar cluster allocation failure during future writeback.

    Write lock the i_data_sem in mpage_release_unused_pages() to fix this
    problem. Ext4's block/cluster accounting code for bigalloc relies on
    i_data_sem for mutual exclusion, as is found in the delayed write path,
    and the locking in mpage_release_unused_pages() is missing.

    Cc: stable@kernel.org
    Reported-by: Ye Bin <yebin10@huawei.com>
    Signed-off-by: Eric Whitney <enwlinux@gmail.com>
    Link: https://lore.kernel.org/r/20220615160530.1928801-1-enwlinux@gmail.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ext4/inode.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -1754,7 +1754,14 @@ static void mpage_release_unused_pages(s
    ext4_lblk_t start, last;
    start = index << (PAGE_SHIFT - inode->i_blkbits);
    last = end << (PAGE_SHIFT - inode->i_blkbits);
    +
    + /*
    + * avoid racing with extent status tree scans made by
    + * ext4_insert_delayed_block()
    + */
    + down_write(&EXT4_I(inode)->i_data_sem);
    ext4_es_remove_extent(inode, start, last - start + 1);
    + up_write(&EXT4_I(inode)->i_data_sem);
    }

    pagevec_init(&pvec, 0);

    \
     
     \ /
      Last update: 2022-08-23 12:07    [W:4.022 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site