lkml.org 
[lkml]   [2022]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] drivers: iio: adc: Rename the LTC249x iio device
From
On 8/22/22 14:51, Ciprian Regus wrote:
> Set the iio device's name based on the chip used.

While the change is correct it breaks the ABI. This needs a bit of a
better explanation what is being done, why, what are the potential
problems, why do we want to do it anyway.

>
> Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
> ---
> drivers/iio/adc/ltc2496.c | 1 +
> drivers/iio/adc/ltc2497-core.c | 2 +-
> drivers/iio/adc/ltc2497.c | 2 ++
> drivers/iio/adc/ltc2497.h | 1 +
> 4 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ltc2496.c b/drivers/iio/adc/ltc2496.c
> index 98338104c24a..86470f49e8ca 100644
> --- a/drivers/iio/adc/ltc2496.c
> +++ b/drivers/iio/adc/ltc2496.c
> @@ -89,6 +89,7 @@ static void ltc2496_remove(struct spi_device *spi)
>
> static struct chip_info ltc2496_info = {
> .resolution = 16,
> + .name = "ltc2496"
> };
>
> static const struct of_device_id ltc2496_of_match[] = {
> diff --git a/drivers/iio/adc/ltc2497-core.c b/drivers/iio/adc/ltc2497-core.c
> index b2752399402c..6dd9ab601904 100644
> --- a/drivers/iio/adc/ltc2497-core.c
> +++ b/drivers/iio/adc/ltc2497-core.c
> @@ -169,7 +169,7 @@ int ltc2497core_probe(struct device *dev, struct iio_dev *indio_dev)
> struct ltc2497core_driverdata *ddata = iio_priv(indio_dev);
> int ret;
>
> - indio_dev->name = dev_name(dev);
> + indio_dev->name = ddata->chip_info->name;
> indio_dev->info = &ltc2497core_info;
> indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->channels = ltc2497core_channel;
> diff --git a/drivers/iio/adc/ltc2497.c b/drivers/iio/adc/ltc2497.c
> index bb5e0d4301e2..a0aad71c8130 100644
> --- a/drivers/iio/adc/ltc2497.c
> +++ b/drivers/iio/adc/ltc2497.c
> @@ -99,9 +99,11 @@ static int ltc2497_remove(struct i2c_client *client)
> static struct chip_info ltc2497_info[] = {
> [TYPE_LTC2497] = {
> .resolution = 16,
> + .name = "ltc2497"
> },
> [TYPE_LTC2499] = {
> .resolution = 24,
> + .name = "ltc2499"
> }
> };
>
> diff --git a/drivers/iio/adc/ltc2497.h b/drivers/iio/adc/ltc2497.h
> index f4d939cfd48b..0e86e38248ee 100644
> --- a/drivers/iio/adc/ltc2497.h
> +++ b/drivers/iio/adc/ltc2497.h
> @@ -12,6 +12,7 @@ enum chip_type {
>
> struct chip_info {
> u32 resolution;
> + char *name;
> };
>
> struct ltc2497core_driverdata {


\
 
 \ /
  Last update: 2022-08-22 16:18    [W:0.142 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site