Messages in this thread | | | Date | Mon, 22 Aug 2022 09:35:03 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] ftrace: makes ops_references_rec() inline |
| |
On Mon, 22 Aug 2022 00:28:58 -0700 Song Liu <song@kernel.org> wrote:
> On Sun, Aug 21, 2022 at 7:31 PM Kuninori Morimoto > <kuninori.morimoto.gx@renesas.com> wrote: > > > > commit 53cd885bc5c3e ("ftrace: Allow IPMODIFY and DIRECT ops on the > > same function") changed ops_references_rec() inline to function, > > thus we will get below error if .config doesn't have CONFIG_MODULES. > > > > CC kernel/trace/ftrace.o > > ${linux}/kernel/trace/ftrace.c:3149:1: error: 'ops_references_rec' \ > > defined but not used [-Werror=unused-function] > > 3149 | ops_references_rec(struct ftrace_ops *ops, struct dyn_ftrace *rec) > > | ^~~~~~~~~~~~~~~~~~ > > cc1: all warnings being treated as errors > > make[2]: *** [${linux}/scripts/Makefile.build:249: kernel/trace/ftrace.o] error 1 > > make[1]: *** [${linux}/scripts/Makefile.build:466: kernel/trace] error 2 > > make: *** [/opt/disk_cd/morimoto/linux/Makefile:1843: kernel] error 2 > > > > This patch makes it to inline again, and fixes the issue. > > > > Fixes: 53cd885bc5c3e ("ftrace: Allow IPMODIFY and DIRECT ops on the same function") > > CC: Song Liu <song@kernel.org> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Acked-by: Song Liu <song@kernel.org> > > Thanks for the fix!
Wrong fix.
The correct fix is here[1], and because the breakage went through the BPF tree, I could not apply it. Now that both the BPF and my tree is in Linus's tree, I can apply it and now will do so.
-- Steve
[1] https://lore.kernel.org/all/20220801084745.1187987-1-wangjingjin1@huawei.com/
| |