lkml.org 
[lkml]   [2022]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC Patch net-next v2] net: dsa: microchip: lan937x: enable interrupt for internal phy link detection
    > +static irqreturn_t lan937x_switch_irq_thread(int irq, void *dev_id)
    > +{
    > + struct ksz_device *dev = dev_id;
    > + irqreturn_t result = IRQ_NONE;
    > + u32 data;
    > + int ret;
    > +
    > + /* Read global interrupt status register */
    > + ret = ksz_read32(dev, REG_SW_INT_STATUS__4, &data);
    > + if (ret)
    > + return result;

    I don't think you can return negative error numbers here.

    > +
    > + if (data & POR_READY_INT) {
    > + ret = ksz_write32(dev, REG_SW_INT_STATUS__4, POR_READY_INT);
    > + if (ret)
    > + return result;

    Returning IRQ_NONE here seems wrong. You handle the interrupt, so
    should probably return IRQ_HANDLED.

    Andrew

    \
     
     \ /
      Last update: 2022-08-22 14:59    [W:3.377 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site