Messages in this thread Patch in this message | | | From | Christoph Hellwig <> | Subject | [PATCH 2/3] dma-pool: don't return errors from dma_atomic_pool_init | Date | Mon, 22 Aug 2022 08:12:54 +0200 |
| |
Returning errors from initcalls does not change a thing, thus don't bother with returning -ENOMEM if one of the pool allocations failed.
Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Robin Murphy <robin.murphy@arm.com> --- kernel/dma/pool.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c index 37008d4f6d7af..4b4c59d05e436 100644 --- a/kernel/dma/pool.c +++ b/kernel/dma/pool.c @@ -194,8 +194,6 @@ static size_t calculate_pool_size(unsigned long zone_pages) static int __init dma_atomic_pool_init(void) { - int ret = 0; - /* * If coherent_pool was not used on the command line, default the pool * sizes to 128KB per 1GB of memory, min 128KB, max MAX_ORDER-1. @@ -207,23 +205,17 @@ static int __init dma_atomic_pool_init(void) atomic_pool_kernel = __dma_atomic_pool_init(atomic_pool_size, GFP_KERNEL); - if (!atomic_pool_kernel) - ret = -ENOMEM; if (has_managed_dma()) { atomic_pool_dma = __dma_atomic_pool_init(atomic_pool_size, GFP_KERNEL | GFP_DMA); - if (!atomic_pool_dma) - ret = -ENOMEM; } if (IS_ENABLED(CONFIG_ZONE_DMA32)) { atomic_pool_dma32 = __dma_atomic_pool_init(atomic_pool_size, GFP_KERNEL | GFP_DMA32); - if (!atomic_pool_dma32) - ret = -ENOMEM; } dma_atomic_pool_debugfs_init(); - return ret; + return 0; } postcore_initcall(dma_atomic_pool_init); -- 2.30.2
| |