Messages in this thread | | | Date | Mon, 22 Aug 2022 13:48:52 +0200 | From | Alexander Gordeev <> | Subject | Re: [PATCH] s390: move from strlcpy with unused retval to strscpy |
| |
On Mon, Aug 22, 2022 at 10:37:47AM +0200, Wolfram Sang wrote: > Hi Alexander, > > > Could you please explain why you skipped strlcpy() usage in > > drivers/s390/char/diag_ftp.c and drivers/s390/char/sclp_ftp.c? > > Sure. It is a bit hidden in $subject, but the key is to convert strlcpy > instances for now which do not check the return value. This is the > low-hanging fruit. > > Converting the other uses checking the return value needs to be done > manually and much more carfully. I wanted to this as a second step, but > if you prefer to have everything converted in one go, I can give your > subsystem a priority boost. Would you prefer that?
A follow-up patch is also fine.
I guess, you also wanted a fix for arch/s390/kvm/tests/instr_icpt/main.c in this series.
> Thanks and happy hacking, > > Wolfram
Thanks!
| |