Messages in this thread | | | From | Sedat Dilek <> | Date | Mon, 22 Aug 2022 08:11:44 +0200 | Subject | Re: [PATCH v2] asm goto: eradicate CC_HAS_ASM_GOTO |
| |
On Sun, Aug 21, 2022 at 7:13 PM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > Applied directly, just because I love seeing old nasty stuff like this go away. > > Linus
Hi,
Small nitpick:
--- a/arch/x86/include/asm/rmwcc.h +++ b/arch/x86/include/asm/rmwcc.h ... -#if !defined(__GCC_ASM_FLAG_OUTPUTS__) && defined(CONFIG_CC_HAS_ASM_GOTO) +#ifndef __GCC_ASM_FLAG_OUTPUTS__ ... -#else /* defined(__GCC_ASM_FLAG_OUTPUTS__) || !defined(CONFIG_CC_HAS_ASM_GOTO) */ +#else /* defined(__GCC_ASM_FLAG_OUTPUTS__) */ ... -#endif /* defined(__GCC_ASM_FLAG_OUTPUTS__) || !defined(CONFIG_CC_HAS_ASM_GOTO) */ +#endif /* defined(__GCC_ASM_FLAG_OUTPUTS__) */
Shouldn't that be...
#if !defined(__GCC_ASM_FLAG_OUTPUTS__)
...to fit the 2 comments?
Best regards, -Sedat-
| |