Messages in this thread | | | Date | Mon, 22 Aug 2022 04:30:05 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] powerpc: export cpu_smallcore_map for modules |
| |
On Mon, Aug 22, 2022 at 01:40:23PM +1000, Michael Ellerman wrote: > Randy Dunlap <rdunlap@infradead.org> writes: > > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask(). > > This is an inline function on powerpc which references > > cpu_smallcore_map. > > > > Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"") > > Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core") > > That 2nd commit is not in mainline, only linux-next. > > I don't mind merging this fix preemptively, but is that SHA stable?
I really do not think this has any business being exported at all.
kfd_queue_work is not something that should be done in a driver. Something like this belongs into the workqueue core, not in an underdocumented helper in a random driver.
Drm guys: once again, please please work with the maintainers instead of just making up random stuff in the drivers.
| |