Messages in this thread | | | Date | Mon, 22 Aug 2022 08:04:56 +0200 | From | Horatiu Vultur <> | Subject | Re: [PATCH 1/2] dt-bindings: lan966x-otpc: document Lan966X OTPC |
| |
The 08/19/2022 09:52, Krzysztof Kozlowski wrote:
Hi Krzysztof,
> > On 18/08/2022 19:44, Horatiu Vultur wrote: > > Document Lan966x OTP controller. > > > > + > > +properties: > > + compatible: > > + items: > > + - const: microchip,lan966x-otpc > > No wildcards in compatible (which will also affect the file name as it > should match the compatible).
Ok, I will replace lan966x with lan966 as the SoC is defined (SOC_LAN966)
> > > + - const: syscon > > Is OTP controller also system controller register region? This is a bit > odd and looks like hack not to use nvmem subsystem.
That was a copy paste mistake. The OTP controller is not a system controller register region.
> > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + otpc: otp@e0021000 { > > + compatible = "microchip,lan966x-otpc", "syscon"; > > + reg = <0xe0021000 0x300>; > > + }; > > + > > +... > > > Best regards, > Krzysztof
-- /Horatiu
| |