Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 22 Aug 2022 10:06:03 +0200 | Subject | Re: [PATCH] platform/renesas: fix repeated words in comments |
| |
Hi Wangjianli,
On Sun, Aug 21, 2022 at 4:58 PM wangjianli <wangjianli@cdjrlc.com> wrote: > Delete the redundant word 'on'. > > Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
Thanks for your patch!
> --- a/drivers/media/platform/renesas/renesas-ceu.c > +++ b/drivers/media/platform/renesas/renesas-ceu.c > @@ -1101,7 +1101,7 @@ static int ceu_open(struct file *file) > return ret; > > mutex_lock(&ceudev->mlock); > - /* Causes soft-reset and sensor power on on first open */ > + /* Causes soft-reset and sensor power on first open */
The double "on" is actually correct. Please ask yourself the question: "When should the sensor be powered on?". Answer: "On first open".
Personally, I would have written "power-on" instead of "power on" (cfr. "soft-reset"), so perhaps it's a good idea to make that change, to prevent the next person looking for double words falling for this again?
> ret = pm_runtime_resume_and_get(ceudev->dev); > mutex_unlock(&ceudev->mlock);
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |