Messages in this thread Patch in this message | | | From | Miaohe Lin <> | Subject | [PATCH v2 3/6] mm, hwpoison: fix extra put_page() in soft_offline_page() | Date | Tue, 23 Aug 2022 11:23:43 +0800 |
| |
When hwpoison_filter() refuses to soft offline a page, the page refcnt incremented previously by MF_COUNT_INCREASED would have been consumed via get_hwpoison_page() if ret <= 0. So the put_ref_page() here will put the extra one. Remove it to fix the issue.
Fixes: 9113eaf331bf ("mm/memory-failure.c: add hwpoison_filter for soft offline") Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com> --- mm/memory-failure.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c index ecd42d717c6f..1d79e693f1b9 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2575,8 +2575,6 @@ int soft_offline_page(unsigned long pfn, int flags) if (hwpoison_filter(page)) { if (ret > 0) put_page(page); - else - put_ref_page(ref_page); mutex_unlock(&mf_mutex); return -EOPNOTSUPP; -- 2.23.0
| |