lkml.org 
[lkml]   [2022]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net v2 RESEND] net: neigh: don't call kfree_skb() under spin_lock_irqsave()
From
On 22/08/2022 05:53, Yang Yingliang wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with interrupts being disabled. So add all skb to
> a tmp list, then free them after spin_unlock_irqrestore() at
> once.
>
> Fixes: 66ba215cb513 ("neigh: fix possible DoS due to net iface start/stop loop")
> Suggested-by: Denis V. Lunev <den@openvz.org>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
> move all skb to a tmp list, then free them after spin_unlock_irqrestore().
> ---
> net/core/neighbour.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>

LGTM,
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>

\
 
 \ /
  Last update: 2022-08-22 09:51    [W:0.062 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site