lkml.org 
[lkml]   [2022]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -next 5/5] landlock: update chmod and chown support in document

    On 22/08/2022 13:47, Xiu Jianfeng wrote:
    > update LANDLOCK_ACCESS_FS_{CHMOD, CHOWN} support and add abi change
    > in the document.
    >
    > Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
    > ---
    > Documentation/userspace-api/landlock.rst | 8 +++++++-
    > 1 file changed, 7 insertions(+), 1 deletion(-)
    >
    > diff --git a/Documentation/userspace-api/landlock.rst b/Documentation/userspace-api/landlock.rst
    > index 2509c2fbf98f..05ab338db529 100644
    > --- a/Documentation/userspace-api/landlock.rst
    > +++ b/Documentation/userspace-api/landlock.rst
    > @@ -61,7 +61,9 @@ the need to be explicit about the denied-by-default access rights.
    > LANDLOCK_ACCESS_FS_MAKE_BLOCK |
    > LANDLOCK_ACCESS_FS_MAKE_SYM |
    > LANDLOCK_ACCESS_FS_REFER |
    > - LANDLOCK_ACCESS_FS_TRUNCATE,
    > + LANDLOCK_ACCESS_FS_TRUNCATE |
    > + LANDLOCK_ACCESS_FS_CHMOD |
    > + LANDLOCK_ACCESS_FS_CHOWN
    > };
    >
    > Because we may not know on which kernel version an application will be
    > @@ -90,6 +92,10 @@ the ABI.
    > case 2:
    > /* Removes LANDLOCK_ACCESS_FS_TRUNCATE for ABI < 3 */
    > ruleset_attr.handled_access_fs &= ~LANDLOCK_ACCESS_FS_TRUNCATE;

    There is a missing fall-through attribute here.


    > + case 3:
    > + /* Removes LANDLOCK_ACCESS_FS_{CHMOD, CHOWN} for ABI < 4 */
    > + ruleset_attr.handled_access_fs &= ~(LANDLOCK_ACCESS_FS_CHMOD |
    > + LANDLOCK_ACCESS_FS_CHOWN);
    > }
    >
    > This enables to create an inclusive ruleset that will contain our rules.

    \
     
     \ /
      Last update: 2022-08-22 23:28    [W:3.360 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site