Messages in this thread | | | Date | Mon, 22 Aug 2022 14:24:50 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power |
| |
On Sat, Aug 20, 2022 at 12:46:55PM +0530, Mithil Bavishi wrote: > Adds documentation for the twl6030 power driver. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com> > --- > .../bindings/power/reset/twl6030-power.txt | 31 +++++++++++++++++++
New bindings must be DT schema format.
> 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/twl6030-power.txt > > diff --git a/Documentation/devicetree/bindings/power/reset/twl6030-power.txt b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt > new file mode 100644 > index 000000000..946bb3d9f > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt > @@ -0,0 +1,31 @@ > +Texas Instruments TWL family (twl6030) reset and power management module > + > +For now, the binding only supports the complete shutdown of the system after > +poweroff. > + > +Required properties: > +- compatible : must be > + "ti,twl6030-power" > + > +Optional properties: > + > +- ti,system-power-controller: This indicates that TWL6030 is the
We have a generic property for this.
> + power supply master of the system. With this flag, the chip will > + initiate an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > + system poweroffs. > + > +Example: > +&i2c1 { > + clock-frequency = <2600000>; > + > + twl: twl@48 { > + reg = <0x48>; > + interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > + interrupt-parent = <&intc>; > + > + twl_power: power { > + compatible = "ti,twl6030-power"; > + ti,system-power-controller;
Why do you need a child node here? There aren't any resources for the sub-block.
Rob
| |