lkml.org 
[lkml]   [2022]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH RFC v1 2/2] devicetree: bindings: bus: add Wiegand driver documentation
On Thu, Jul 28, 2022 at 11:17 AM Martin Zaťovič <m.zatovic1@gmail.com> wrote:

> Wiegand write-only driver requires definitions of two GPIO lines
> in the devicetree. This adds the documentation of their
> definitions.

On top of the other comments:

> + Both data lines are initially pulled up.

That makes it sound like they are both open drain, right? Just like I2C.

> + wiegand-data-hi-gpios:
> + wiegand-data-lo-gpios:

So these should be tagged with (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)
See the I2C bindings in
Documentation/devicetree/bindings/i2c/i2c-gpio.yaml

> + wiegand-data-hi-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
> + wiegand-data-lo-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>;

(GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN) on both then!

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2022-08-22 09:23    [W:0.098 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site