Messages in this thread | | | Date | Mon, 22 Aug 2022 13:45:34 -0500 | From | Rob Herring <> | Subject | Re: [PATCH net-next v1 2/7] dt-bindings: net: phy: add PoDL PSE property |
| |
On Fri, Aug 19, 2022 at 02:01:04PM +0200, Oleksij Rempel wrote: > Add property to reference node representing a PoDL Power Sourcing Equipment. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index ed1415a4381f2..49c74e177c788 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -144,6 +144,12 @@ properties: > Mark the corresponding energy efficient ethernet mode as > broken and request the ethernet to stop advertising it. > > + ieee802.3-podl-pse: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Specifies a reference to a node representing a Power over Data Lines > + Power Sourcing Equipment.
Ah, here is the consumer.
Why do you anything more than just a -supply property here for the PoE/PoDL supply? The only reason I see is you happen to want a separate driver for this and a separate node happens to be a convenient way to instantiate drivers in Linux. Convince me otherwise.
Rob
| |