| Date | Sun, 21 Aug 2022 00:00:07 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 05/11] hexagon: mm: Convert to GENERIC_IOREMAP |
| |
On Sat, Aug 20, 2022 at 08:31:19AM +0800, Baoquan He wrote: > With it, the old ioremap() and iounmap() can be perfectly removed > since they are duplicated with the standard functions.
Can you write a somewhat better commit message explaining that it switches to the generic code that has equivalent functionality?
> +#define ioremap_uc(addr, size) ioremap((addr), (size))
This is wrong and hexagon should use the asm-generic version of ioremap_uc that returns NULL.
|