Messages in this thread | | | Subject | Re: [PATCH -next] driver core: switch to use dev_err_probe() | From | Yang Yingliang <> | Date | Mon, 22 Aug 2022 10:10:22 +0800 |
| |
Hi,
On 2022/8/19 17:42, Greg KH wrote: > On Fri, Aug 19, 2022 at 05:46:56PM +0800, Yang Yingliang wrote: >> Use dev_err_probe() to simplify code and print error code. >> >> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >> --- >> drivers/base/core.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/base/core.c b/drivers/base/core.c >> index 753e7cca0f40..e51a09f9d0ec 100644 >> --- a/drivers/base/core.c >> +++ b/drivers/base/core.c >> @@ -2507,11 +2507,9 @@ static ssize_t uevent_store(struct device *dev, struct device_attribute *attr, >> int rc; >> >> rc = kobject_synth_uevent(&dev->kobj, buf, count); >> - >> - if (rc) { >> - dev_err(dev, "uevent: failed to send synthetic uevent\n"); >> - return rc; >> - } >> + if (rc) >> + return dev_err_probe(dev, rc, >> + "uevent: failed to send synthetic uevent\n"); > I do not understand this at all, this is not on the probe path at all, > so why is this function needed? > > Have you tested this? What was the resulting output before and after > this change? Yes, after this change, the error code will be print. > > thanks, > > greg k-h > .
| |