Messages in this thread | | | Date | Sun, 21 Aug 2022 12:07:05 +0800 | From | kernel test robot <> | Subject | [ammarfaizi2-block:viro/vfs/work.termios2 4/8] arch/alpha/kernel/termios.c:5:5: warning: no previous prototype for 'user_termio_to_kernel_termios' |
| |
tree: https://github.com/ammarfaizi2/linux-block viro/vfs/work.termios2 head: efc5ae91c846283431afc7bfc57e947bf1fd4158 commit: 7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5 [4/8] termios: start unifying non-UAPI parts of asm/termios.h config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220821/202208211203.xvc2wVjR-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/ammarfaizi2/linux-block/commit/7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5 git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block viro/vfs/work.termios2 git checkout 7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash arch/alpha/kernel/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> arch/alpha/kernel/termios.c:5:5: warning: no previous prototype for 'user_termio_to_kernel_termios' [-Wmissing-prototypes] 5 | int user_termio_to_kernel_termios(struct ktermios *termios, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> arch/alpha/kernel/termios.c:33:5: warning: no previous prototype for 'kernel_termios_to_user_termio' [-Wmissing-prototypes] 33 | int kernel_termios_to_user_termio(struct termio __user *termio, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/user_termio_to_kernel_termios +5 arch/alpha/kernel/termios.c
8eb5cc958018d9 Al Viro 2022-08-20 4 8eb5cc958018d9 Al Viro 2022-08-20 @5 int user_termio_to_kernel_termios(struct ktermios *termios, 8eb5cc958018d9 Al Viro 2022-08-20 6 struct termio __user *termio) 8eb5cc958018d9 Al Viro 2022-08-20 7 { 8eb5cc958018d9 Al Viro 2022-08-20 8 struct termio v; 8eb5cc958018d9 Al Viro 2022-08-20 9 bool canon; 8eb5cc958018d9 Al Viro 2022-08-20 10 8eb5cc958018d9 Al Viro 2022-08-20 11 if (copy_from_user(&v, termio, sizeof(struct termio))) 8eb5cc958018d9 Al Viro 2022-08-20 12 return -EFAULT; 8eb5cc958018d9 Al Viro 2022-08-20 13 8eb5cc958018d9 Al Viro 2022-08-20 14 termios->c_iflag = (0xffff0000 & termios->c_iflag) | v.c_iflag; 8eb5cc958018d9 Al Viro 2022-08-20 15 termios->c_oflag = (0xffff0000 & termios->c_oflag) | v.c_oflag; 8eb5cc958018d9 Al Viro 2022-08-20 16 termios->c_cflag = (0xffff0000 & termios->c_cflag) | v.c_cflag; 8eb5cc958018d9 Al Viro 2022-08-20 17 termios->c_lflag = (0xffff0000 & termios->c_lflag) | v.c_lflag; 8eb5cc958018d9 Al Viro 2022-08-20 18 termios->c_line = (0xffff0000 & termios->c_lflag) | v.c_line; 8eb5cc958018d9 Al Viro 2022-08-20 19 8eb5cc958018d9 Al Viro 2022-08-20 20 canon = v.c_lflag & ICANON; 8eb5cc958018d9 Al Viro 2022-08-20 21 termios->c_cc[VINTR] = v.c_cc[_VINTR]; 8eb5cc958018d9 Al Viro 2022-08-20 22 termios->c_cc[VQUIT] = v.c_cc[_VQUIT]; 8eb5cc958018d9 Al Viro 2022-08-20 23 termios->c_cc[VERASE] = v.c_cc[_VERASE]; 8eb5cc958018d9 Al Viro 2022-08-20 24 termios->c_cc[VKILL] = v.c_cc[_VKILL]; 8eb5cc958018d9 Al Viro 2022-08-20 25 termios->c_cc[VEOL2] = v.c_cc[_VEOL2]; 8eb5cc958018d9 Al Viro 2022-08-20 26 termios->c_cc[VSWTC] = v.c_cc[_VSWTC]; 8eb5cc958018d9 Al Viro 2022-08-20 27 termios->c_cc[canon ? VEOF : VMIN] = v.c_cc[_VEOF]; 8eb5cc958018d9 Al Viro 2022-08-20 28 termios->c_cc[canon ? VEOL : VTIME] = v.c_cc[_VEOL]; 8eb5cc958018d9 Al Viro 2022-08-20 29 8eb5cc958018d9 Al Viro 2022-08-20 30 return 0; 8eb5cc958018d9 Al Viro 2022-08-20 31 } 8eb5cc958018d9 Al Viro 2022-08-20 32 8eb5cc958018d9 Al Viro 2022-08-20 @33 int kernel_termios_to_user_termio(struct termio __user *termio,
:::::: The code at line 5 was first introduced by commit :::::: 8eb5cc958018d99c96d15cf9637fd07531551802 termios: uninline conversion helpers
:::::: TO: Al Viro <viro@zeniv.linux.org.uk> :::::: CC: Al Viro <viro@zeniv.linux.org.uk>
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |