Messages in this thread | | | Date | Sun, 21 Aug 2022 13:28:58 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2] sched/all: Change all BUG_ON() instances in the scheduler to WARN_ON_ONCE() |
| |
* Mel Gorman <mgorman@suse.de> wrote:
> For the rest, I didn't see obvious recovery paths that would allow the > system to run predictably. Any of them firing will have unpredictable > consequences (e.g. move_queued_task firing would be fun if it was a > per-cpu kthread). Depending on which warning triggers, the remaining life > of the system may be very short but maybe long enough to be logged even > if system locks up shortly afterwards.
Correct. I'd prefer to keep all these warnings 'simple' - i.e. no attempted recovery & control flow, unless we ever expect these to trigger.
I.e. instead of adding a 'goto' I'd prefer if we removed most of the ones you highlighted. But wanted to keep this first patch simple.
Thanks,
Ingo
| |