lkml.org 
[lkml]   [2022]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 0/3] remove useless files
From
Hi Nam,

On 8/20/22 20:00, Nam Cao wrote:
> Delete odm_NoiseMonitor.c and odm_NoiseMonitor.h because they are
> useless. The first 2 commits are preparation, and the final commit is
> actual removal.
>
> v2: Add new patch to remove the file from Makefile, otherwise there is
> build error as reported by kernel test bot.
> v3: Squash some commits together. The patchset functionally remains
> the same.
>
> Nam Cao (3):
> staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor
> staging: rtl8723bs: remove member noise_level from struct dm_odm_t
> staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c
>
> drivers/staging/rtl8723bs/Makefile | 1 -
> drivers/staging/rtl8723bs/hal/odm.h | 2 -
> .../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 130 ------------------
> .../staging/rtl8723bs/hal/odm_NoiseMonitor.h | 39 ------
> drivers/staging/rtl8723bs/hal/odm_precomp.h | 1 -
> 5 files changed, 173 deletions(-)
> delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
> delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h

Thank you for the new version, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans

\
 
 \ /
  Last update: 2022-08-20 21:16    [W:0.408 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site