lkml.org 
[lkml]   [2022]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCHES] termios.h cleanups
On Sat, Aug 20, 2022 at 11:14:19AM -0700, Linus Torvalds wrote:
> On Fri, Aug 19, 2022 at 8:34 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > It takes the helpers and INIT_C_CC into new header (termios-internal.h),
> > with defaults being in linux/termios-internal.h, unless an arch-specific
> > variant is provided in asm/termios-internal.h (only alpha and sparc end
> > up needing that). Files that need that stuff (all 4 of them) include
> > linux/termios-internal.h.
>
> I don't see anything obviously wrong here, and my main reaction is
> actually that I wish this went a bit further, and moved the whole
> kernel_termios_to_user_termios stuff into C code rather than having
> them in headers.
>
> I don't think it's really worth inlining those things, and I wonder if
> we could just have the default "just copy directly to/from user space"
> as __weak functions, and then allow sparc and alpha to override them?

Umm... Might as well, I guess... Where to put those, though?
drivers/tty/tty_ioctl.c is not an option, unfortunately - it'll pick
the local definitions, __weak or no __weak. drivers/tty/termios.c
just for those? Looks just as convoluted as having those as inlines...

\
 
 \ /
  Last update: 2022-08-20 20:47    [W:0.081 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site