Messages in this thread | | | Date | Sat, 20 Aug 2022 09:11:04 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 4/4] tracing/eprobes: Have event probes be consistent with kprobes and uprobes |
| |
On Sat, 20 Aug 2022 22:04:42 +0900 Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > For "comm", if "comm" is used and the event being attached to does not > > have the "comm" field, then make it the "$comm" that kprobes has. This is > > consistent to the way histograms and filters work. > > Hmm, I think I would better allow user to use $COMM to get comm string > for kprobe/uprobe event users too. (There are many special variables...) > Anyway, this looks good to me. > > Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
I could add this on top of the patch series.
-- Steve
| |