Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Sat, 20 Aug 2022 13:57:09 +0200 | Subject | Re: [PATCH] thermal/core: Fix lockdep_assert() warning |
| |
On Fri, Aug 12, 2022 at 3:54 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > On 12/08/2022 15:34, Marek Szyprowski wrote: > > On 12.08.2022 15:12, Daniel Lezcano wrote: > >> The function thermal_zone_device_is_enabled() must be called with the > >> thermal zone lock held. In the resume path, it is called without. > >> > >> As the thermal_zone_device_is_enabled() is also checked in > >> thermal_zone_device_update(), do the check in resume() function is > >> pointless, except for saving an extra initialization which does not > >> hurt if it is done in all the cases. > >> > >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > > > This fixes the warning I've reported. Feel free to add: > > > > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> > > > > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > > Great, thanks for testing
Do you want me to apply this for -rc3?
| |