Messages in this thread | | | Date | Sat, 20 Aug 2022 04:50:58 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 1/2] watchdog/hpwdt: Build issue for ARM64 platforms |
| |
On Fri, Aug 19, 2022 at 05:14:22PM -0600, Jerry Hoemann wrote: > Fixes commit d48b0e173715 ("x86, nmi, drivers: Fix nmi splitup build bug") > > Include <asm/nmi.h> only if CONFIG_HPWDT_NMI_DECODING is defined. > The descrition doesn't describe the problem (what is the build issue ?), the fix reference should be a Fixes: tag, and the subject should describe what is done, not the problem (ie "Fix build issue...")
Thanks, Guenter
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com> > --- > drivers/watchdog/hpwdt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index a5006a58e0db..f79f932bca14 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -20,7 +20,9 @@ > #include <linux/pci_ids.h> > #include <linux/types.h> > #include <linux/watchdog.h> > +#ifdef CONFIG_HPWDT_NMI_DECODING > #include <asm/nmi.h> > +#endif > #include <linux/crash_dump.h> > > #define HPWDT_VERSION "2.0.4" > -- > 2.37.1 >
| |