lkml.org 
[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] staging: r8188eu: convert rtw_set_802_11_add_wep error code semantics
On Tue, Aug 02, 2022 at 11:10:21PM +0300, Pavel Skripkin wrote:
> Hi Phillip,
>
> Phillip Potter <phil@philpotter.co.uk> says:
> > - if (!rtw_set_802_11_add_wep(padapter, &wep)) {
> > + if (rtw_set_802_11_add_wep(padapter, &wep)) {
> > if (rf_on == pwrpriv->rf_pwrstate)
> > ret = -EOPNOTSUPP;
> > goto exit;
>
> is it intentional to ignore an error in case of rf_on !=
> pwrpriv->rf_pwrstate?
>
>

Hi Pavel,

Somewhat yes, in the sense that this is existing behaviour and changing
it is a semantic change in the driver, thus arguably outside the scope
of a patch/patch set that is intended to just focus on error code
handling (moving from _SUCCESS/_FAIL to 0 and -EWHATEVER).

Not fixed to that by any means though, if you would prefer it be
restructured as well. I need to do a V2 for this anyway.

Regards,
Phil

\
 
 \ /
  Last update: 2022-08-03 00:16    [W:0.154 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site