[lkml]   [2022]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [GIT PULL] Smack patches for v6.0
On Mon, Aug 1, 2022 at 1:13 PM Casey Schaufler <> wrote:
> There are two minor code clean-ups. One removes a touch of
> dead code and the other replaces an instance of kzalloc + strncpy
> with kstrndup.

Hmm. That second one looks like it really should have just used
"kmemdup()" (and a zero termination) instead, since it has already
done all the string length calculations.

Oh well. I guess the strndup() works too, but it seems kind of odd to
do a strnlen() there when you have literally limited 'len' to smaller
than the string you are going to duplicate.


 \ /
  Last update: 2022-08-03 00:12    [W:0.033 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site